Checkpoint connector bugfixes #10647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstjohn
commented
Sep 26, 2024
5 tasks
jstjohn
force-pushed
the
jstjohn/nemo_checkpoint_connector_fixes
branch
4 times, most recently
from
6069101
to
a4ad2d7
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
akoumpa
reviewed
Sep 27, 2024
akoumpa
reviewed
Sep 27, 2024
|
[🤖]: Hi @jstjohn 👋, I just wanted to let you know that, you know, a CICD pipeline for this PR just finished successfully ✨ So it might be time to merge this PR or like to get some approvals 🚀 But I'm just a 🤖 so I'll leave it you what to do next. Have a great day! //cc @ko3n1g |
jstjohn
force-pushed
the
jstjohn/nemo_checkpoint_connector_fixes
branch
from
a4ad2d7
to
04a9660
Compare
akoumpa
previously approved these changes
Sep 30, 2024
|
CI seems to have an issue with CI assets; will retry it later. |
jstjohn
force-pushed
the
jstjohn/nemo_checkpoint_connector_fixes
branch
from
acd3b68
to
ffa03ab
Compare
akoumpa
force-pushed
the
jstjohn/nemo_checkpoint_connector_fixes
branch
from
32365ea
to
499db1c
Compare
…_utils instead (to avoid side-effects to nemo1.0 ckpts) Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
akoumpa
force-pushed
the
jstjohn/nemo_checkpoint_connector_fixes
branch
from
499db1c
to
41b9a65
Compare
Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>
akoumpa
previously approved these changes
Oct 4, 2024
|
[🤖]: Hi @jstjohn 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
akoumpa
approved these changes
Oct 5, 2024
ko3n1g
pushed a commit
that referenced
this pull request
Oct 5, 2024
* Update checkpoint connector nemo_save to match current folder heirarchy Signed-off-by: John St John <jstjohn@nvidia.com> * Address PR feedback Signed-off-by: John St John <jstjohn@nvidia.com> * Address divergent code issue in ckpt_to_dir Signed-off-by: John St John <jstjohn@nvidia.com> * revert changes to nemo.utils.model_utils and use model.lightning.ckpt_utils instead (to avoid side-effects to nemo1.0 ckpts) Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * Apply isort and black reformatting Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> --------- Signed-off-by: John St John <jstjohn@nvidia.com> Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> Co-authored-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Co-authored-by: akoumpa <akoumpa@users.noreply.github.com>
|
This needs #10786 |
8 tasks
monica-sekoyan
pushed a commit
that referenced
this pull request
Oct 14, 2024
* Update checkpoint connector nemo_save to match current folder heirarchy Signed-off-by: John St John <jstjohn@nvidia.com> * Address PR feedback Signed-off-by: John St John <jstjohn@nvidia.com> * Address divergent code issue in ckpt_to_dir Signed-off-by: John St John <jstjohn@nvidia.com> * revert changes to nemo.utils.model_utils and use model.lightning.ckpt_utils instead (to avoid side-effects to nemo1.0 ckpts) Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * Apply isort and black reformatting Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> --------- Signed-off-by: John St John <jstjohn@nvidia.com> Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> Co-authored-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Co-authored-by: akoumpa <akoumpa@users.noreply.github.com>
yashaswikarnati
pushed a commit
that referenced
this pull request
Oct 20, 2024
* Update checkpoint connector nemo_save to match current folder heirarchy Signed-off-by: John St John <jstjohn@nvidia.com> * Address PR feedback Signed-off-by: John St John <jstjohn@nvidia.com> * Address divergent code issue in ckpt_to_dir Signed-off-by: John St John <jstjohn@nvidia.com> * revert changes to nemo.utils.model_utils and use model.lightning.ckpt_utils instead (to avoid side-effects to nemo1.0 ckpts) Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * Apply isort and black reformatting Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> --------- Signed-off-by: John St John <jstjohn@nvidia.com> Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> Co-authored-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Co-authored-by: akoumpa <akoumpa@users.noreply.github.com>
akoumpa
added a commit
that referenced
this pull request
Oct 21, 2024
* Update checkpoint connector nemo_save to match current folder heirarchy Signed-off-by: John St John <jstjohn@nvidia.com> * Address PR feedback Signed-off-by: John St John <jstjohn@nvidia.com> * Address divergent code issue in ckpt_to_dir Signed-off-by: John St John <jstjohn@nvidia.com> * revert changes to nemo.utils.model_utils and use model.lightning.ckpt_utils instead (to avoid side-effects to nemo1.0 ckpts) Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * Apply isort and black reformatting Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> --------- Signed-off-by: John St John <jstjohn@nvidia.com> Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> Co-authored-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Co-authored-by: akoumpa <akoumpa@users.noreply.github.com> Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
pablo-garay
pushed a commit
that referenced
this pull request
Oct 22, 2024
…0.0` (#10770) * Checkpoint connector bugfixes (#10647) * Update checkpoint connector nemo_save to match current folder heirarchy Signed-off-by: John St John <jstjohn@nvidia.com> * Address PR feedback Signed-off-by: John St John <jstjohn@nvidia.com> * Address divergent code issue in ckpt_to_dir Signed-off-by: John St John <jstjohn@nvidia.com> * revert changes to nemo.utils.model_utils and use model.lightning.ckpt_utils instead (to avoid side-effects to nemo1.0 ckpts) Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * Apply isort and black reformatting Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> --------- Signed-off-by: John St John <jstjohn@nvidia.com> Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> Co-authored-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Co-authored-by: akoumpa <akoumpa@users.noreply.github.com> Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * Apply isort and black reformatting Signed-off-by: ko3n1g <ko3n1g@users.noreply.github.com> Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * use ckpt_to_weights_subdir in restore (#10786) * use ckpt_to_weights_subdir in restore Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * make ckpt_to_{weight,context}_subdir idempotent Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * Apply isort and black reformatting Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> --------- Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> Co-authored-by: akoumpa <akoumpa@users.noreply.github.com> Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * py syntax fix Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * Apply isort and black reformatting Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> --------- Signed-off-by: John St John <jstjohn@nvidia.com> Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> Signed-off-by: ko3n1g <ko3n1g@users.noreply.github.com> Signed-off-by: Alexandros Koumparoulis <153118171+akoumpa@users.noreply.github.com> Co-authored-by: John St. John <jstjohn@users.noreply.github.com> Co-authored-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Co-authored-by: akoumpa <akoumpa@users.noreply.github.com> Co-authored-by: ko3n1g <ko3n1g@users.noreply.github.com> Co-authored-by: Alexandros Koumparoulis <153118171+akoumpa@users.noreply.github.com>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 5, 2024
* Update checkpoint connector nemo_save to match current folder heirarchy Signed-off-by: John St John <jstjohn@nvidia.com> * Address PR feedback Signed-off-by: John St John <jstjohn@nvidia.com> * Address divergent code issue in ckpt_to_dir Signed-off-by: John St John <jstjohn@nvidia.com> * revert changes to nemo.utils.model_utils and use model.lightning.ckpt_utils instead (to avoid side-effects to nemo1.0 ckpts) Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * Apply isort and black reformatting Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> --------- Signed-off-by: John St John <jstjohn@nvidia.com> Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> Co-authored-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Co-authored-by: akoumpa <akoumpa@users.noreply.github.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Get checkpoint connector working for bionemo (see NVIDIA/bionemo-framework#180)
Changelog
/weightsand/contextsubdirectory scheme so checkpoint loaders work properly with checkpoints created by this method.